[NDR-293] Use EICAR file in virus test #899
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
megan-bower4
temporarily deployed
to
development
GitHub Actions
Inactive
megan-bower4
commented
Nov 21, 2025
tim-knight-nhs
previously approved these changes
Nov 25, 2025
megan-bower4
force-pushed
the
NDR-293
branch
from
be0fcc7 to
d7e8909
Compare
megan-bower4
had a problem deploying
to
development
GitHub Actions
Failure
megan-bower4
force-pushed
the
NDR-293
branch
from
d7e8909 to
b0c6134
Compare
megan-bower4
temporarily deployed
to
development
GitHub Actions
Inactive
megan-bower4
temporarily deployed
to
development
GitHub Actions
Inactive
megan-bower4
temporarily deployed
to
development
GitHub Actions
Inactive
megan-bower4
temporarily deployed
to
development
GitHub Actions
Inactive
megan-bower4
temporarily deployed
to
development
GitHub Actions
Inactive
megan-bower4
temporarily deployed
to
development
GitHub Actions
Inactive
megan-bower4
had a problem deploying
to
pre-prod
GitHub Actions
Failure
megan-bower4
had a problem deploying
to
pre-prod
GitHub Actions
Failure
megan-bower4
temporarily deployed
to
development
GitHub Actions
Inactive
megan-bower4
temporarily deployed
to
development
GitHub Actions
Inactive
megan-bower4
had a problem deploying
to
pre-prod
GitHub Actions
Failure
megan-bower4
had a problem deploying
to
pre-prod
GitHub Actions
Failure
megan-bower4
had a problem deploying
to
pre-prod
GitHub Actions
Failure
megan-bower4
had a problem deploying
to
pre-prod
GitHub Actions
Failure
megan-bower4
had a problem deploying
to
pre-prod
GitHub Actions
Failure
megan-bower4
temporarily deployed
to
development
GitHub Actions
Inactive
jameslinnell
approved these changes
Dec 11, 2025
megan-bower4
force-pushed
the
NDR-293
branch
from
a8b6b81 to
753ae64
Compare
megan-bower4
temporarily deployed
to
development
GitHub Actions
Inactive
|
matthewpotter2-nhs
approved these changes
Dec 11, 2025
lillie-dae
pushed a commit
that referenced
this pull request
Dec 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Jira ticket: NDR-293
Description
I want the backend E2E tests to test uploading an infected file so that I can have confidence in the virus scan.
Context
I have refactored the existing E2E upload test to upload the EICAR test virus file instead of using a dummy file. This will ensure the virus scan will pick this up on pre-prod (where the service isn't mocked).
Checklist
I have run git pre-commits.(WIP)Deploy - Sandbox- workflow runSANDBOX Full- Deploy feature branch to sandbox- workflow run